Re: [GIT PULL] sound updates for 4.19-rc1

From: Linus Torvalds
Date: Wed Aug 15 2018 - 22:01:02 EST

On Wed, Aug 15, 2018 at 6:27 PM Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> I have no idea _why_, but it's consistent, and it bisects down to
> c647f806b8c2 "ALSA: hda - Allow multiple ADCs for mic mute LED controls"
> where the previous commit works fine, but that commit definitely
> causes the problem.


That commit changes the return value of the
snd_hda_gen_add_micmute_led(), but doesn't change any of the callers.

Now, almost no caller actually checks the return value.


There is *one* caller that does, though:


And yes, the laptop that breaks is a Dell. An XPS13.

I bet that instead of reverting, I can just change that

dell_micmute_update) <= 0);

to test for "< 0" instead of "<= 0".