Re: [PATCH v2 3/4] mm/memory_hotplug: Make register_mem_sect_under_node a cb of walk_memory_range

From: Oscar Salvador
Date: Thu Aug 16 2018 - 02:15:57 EST


On Wed, Aug 15, 2018 at 03:21:35PM -0700, Andrew Morton wrote:
> On Fri, 22 Jun 2018 13:18:38 +0200 osalvador@xxxxxxxxxxxxxxxxxx wrote:
>
> > From: Oscar Salvador <osalvador@xxxxxxx>
> >
> > link_mem_sections() and walk_memory_range() share most of the code,
> > so we can use convert link_mem_sections() into a dummy function that calls
> > walk_memory_range() with a callback to register_mem_sect_under_node().
> >
> > This patch converts register_mem_sect_under_node() in order to
> > match a walk_memory_range's callback, getting rid of the
> > check_nid argument and checking instead if the system is still
> > boothing, since we only have to check for the nid if the system
> > is in such state.
> >
> > Signed-off-by: Oscar Salvador <osalvador@xxxxxxx>
> > Suggested-by: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>
>
> We have two tested-by's bu no reviewers or ackers?

Pavel, would you be so kind to review this patch?
It is the only patch from the patchset which did not get a
review.

Thanks!
--
Oscar Salvador
SUSE L3