Re: [PATCH10 3/3] ARM:drm ivip Intel FPGA Video and Image Processing Suite

[Ong, Hean Loong]

On Wed, 2018-08-15 at 14:26 +0200, Noralf TrÃnnes wrote:
> Den 14.08.2018 10.57, skrev Hean-Loong, Ong:
> > 
> > From: Ong Hean Loong <hean.loong.ong@xxxxxxxxx>
> > 
> > Driver for Intel FPGA Video and Image Processing Suite Frame Buffer
> > II.
> > The driver only supports the Intel Arria10 devkit and its variants.
> > This driver can be either loaded staticlly or in modules.
> > The OF device tree binding is located at:
> > Documentation/devicetree/bindings/display/altr,vip-fb2.txt
> > 
> > Signed-off-by: Ong Hean Loong <hean.loong.ong@xxxxxxxxx>
> > ---
> > Â drivers/gpu/drm/KconfigÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂÂ2 +
> > Â drivers/gpu/drm/MakefileÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂÂ1 +
> > Â drivers/gpu/drm/ivip/KconfigÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ14 +++
> > Â drivers/gpu/drm/ivip/MakefileÂÂÂÂÂÂÂÂÂ|ÂÂÂÂ9 ++
> > Â drivers/gpu/drm/ivip/intel_vip_conn.c |ÂÂÂ95 ++++++++++++++++
> > Â drivers/gpu/drm/ivip/intel_vip_core.c |ÂÂ161
> > +++++++++++++++++++++++++++
> > Â drivers/gpu/drm/ivip/intel_vip_drv.hÂÂ|ÂÂÂ52 +++++++++
> > Â drivers/gpu/drm/ivip/intel_vip_of.cÂÂÂ|ÂÂ193
> > +++++++++++++++++++++++++++++++++
> > Â 8 files changed, 527 insertions(+), 0 deletions(-)
> > Â create mode 100644 drivers/gpu/drm/ivip/Kconfig
> > Â create mode 100644 drivers/gpu/drm/ivip/Makefile
> > Â create mode 100644 drivers/gpu/drm/ivip/intel_vip_conn.c
> > Â create mode 100644 drivers/gpu/drm/ivip/intel_vip_core.c
> > Â create mode 100644 drivers/gpu/drm/ivip/intel_vip_drv.h
> > Â create mode 100644 drivers/gpu/drm/ivip/intel_vip_of.c
> > 
> > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> > index cb88528..6b2845b 100644
> > --- a/drivers/gpu/drm/Kconfig
> > +++ b/drivers/gpu/drm/Kconfig
> > @@ -215,6 +215,8 @@ source "drivers/gpu/drm/nouveau/Kconfig"
> > ÂÂ
> > Â source "drivers/gpu/drm/i915/Kconfig"
> > ÂÂ
> > +source "drivers/gpu/drm/ivip/Kconfig"
> > +
> > Â config DRM_VGEM
> > ÂÂ	tristate "Virtual GEM provider"
> > ÂÂ	depends on DRM
> > diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
> > index a6771ce..57205d8 100644
> > --- a/drivers/gpu/drm/Makefile
> > +++ b/drivers/gpu/drm/Makefile
> > @@ -61,6 +61,7 @@ obj-$(CONFIG_DRM_AMDGPU)+= amd/amdgpu/
> > Â obj-$(CONFIG_DRM_MGA)	+= mga/
> > Â obj-$(CONFIG_DRM_I810)	+= i810/
> > Â obj-$(CONFIG_DRM_I915)	+= i915/
> > +obj-$(CONFIG_DRM_IVIP)	+= ivip/
> > Â obj-$(CONFIG_DRM_MGAG200) += mgag200/
> > Â obj-$(CONFIG_DRM_V3D)ÂÂ+= v3d/
> > Â obj-$(CONFIG_DRM_VC4)ÂÂ+= vc4/
> > diff --git a/drivers/gpu/drm/ivip/Kconfig
> > b/drivers/gpu/drm/ivip/Kconfig
> > new file mode 100644
> > index 0000000..1d08b90
> > --- /dev/null
> > +++ b/drivers/gpu/drm/ivip/Kconfig
> > @@ -0,0 +1,14 @@
> > +config DRM_IVIP
> > +ÂÂÂÂÂÂÂÂtristate "Intel FGPA Video and Image Processing"
> > +ÂÂÂÂÂÂÂÂdepends on DRM && OF
> > +ÂÂÂÂÂÂÂÂselect DRM_GEM_CMA_HELPER
> > +ÂÂÂÂÂÂÂÂselect DRM_KMS_HELPER
> > +ÂÂÂÂÂÂÂÂselect DRM_KMS_FB_HELPER
> > +ÂÂÂÂÂÂÂÂselect DRM_KMS_CMA_HELPER
> > +ÂÂÂÂÂÂÂÂhelp
> > +		ÂÂChoose this option if you have an Intel FPGA
> > Arria 10 system
> > +		ÂÂand above with an Intel Display Port IP. This
> > does not support
> > +		ÂÂlegacy Intel FPGA Cyclone V display port.
> > Currently only single
> > +		ÂÂframe buffer is supported. Note that ACPI and
> > X_86 architecture
> > +		ÂÂis not supported for Arria10. If M is selected
> > the module will be
> > +		ÂÂcalled ivip.
> > diff --git a/drivers/gpu/drm/ivip/Makefile
> > b/drivers/gpu/drm/ivip/Makefile
> > new file mode 100644
> > index 0000000..cc55b04
> > --- /dev/null
> > +++ b/drivers/gpu/drm/ivip/Makefile
> > @@ -0,0 +1,9 @@
> > +#
> > +# Makefile for the drm device driver.ÂÂThis driver provides
> > support for the
> > +# Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and
> > higher.
> > +
> > +ccflags-y := -Iinclude/drm
> This shouldn't be necessary AFAIK.
> 
> > 
> > +
> > +obj-$(CONFIG_DRM_IVIP) += ivip.o
> > +ivip-objs := intel_vip_of.o intel_vip_core.o \
> > +	intel_vip_conn.o
> > diff --git a/drivers/gpu/drm/ivip/intel_vip_conn.c
> > b/drivers/gpu/drm/ivip/intel_vip_conn.c
> > new file mode 100644
> > index 0000000..46bb04c
> > --- /dev/null
> > +++ b/drivers/gpu/drm/ivip/intel_vip_conn.c
> > @@ -0,0 +1,95 @@
> Please add an SPDX indentifier at the top of your files and you can
> drop
> the license text.
> 
> Header files use this:
> /* SPDX-License-Identifier: GPL-2.0 */
> 
> C-files uses c++ comment due to reasons:
> // SPDX-License-Identifier: GPL-2.0
> 
> > 
> > +/*
> > + * intel_vip_conn.c -- Intel Video and Image Processing(VIP)
> > + * Frame Buffer II driver
> > + *
> > + * This driver supports the Intel VIP Frame Reader component.
> > + * More info on the hardware can be found in the Intel Video
> > + * and Image Processing Suite User Guide at this address
> > + * http://www.altera.com/literature/ug/ug_vip.pdf.
> > + *
> > + * This program is free software; you can redistribute it and/or
> > modify it
> > + * under the terms and conditions of the GNU General Public
> > License,
> > + * version 2, as published by the Free Software Foundation.
> > + *
> > + * This program is distributed in the hope it will be useful, but
> > WITHOUT
> > + * ANY WARRANTY; without even the implied warranty of
> > MERCHANTABILITY or
> > + * FITNESS FOR A PARTICULAR PURPOSE.ÂÂSee the GNU General Public
> > License for
> > + * more details.
> > + *
> > + * Authors:
> > + * Ong, Hean-Loong <hean.loong.ong@xxxxxxxxx>
> > + *
> > + */
> > +
> > +#include <linux/init.h>
> > +#include <linux/kernel.h>
> > +#include <drm/drm_atomic_helper.h>
> > +#include <drm/drm_crtc_helper.h>
> > +#include <drm/drm_encoder_slave.h>
> > +#include <drm/drm_plane_helper.h>
> > +
> > +static enum drm_connector_status
> > +intelvipfb_drm_connector_detect(struct drm_connector *connector,
> > bool force)
> > +{
> > +	return connector_status_connected;
> > +}
> > +
> > +static void intelvipfb_drm_connector_destroy(struct drm_connector
> > *connector)
> > +{
> > +	drm_connector_unregister(connector);
> > +	drm_connector_cleanup(connector);
> > +}
> > +
> > +static const struct drm_connector_funcs
> > intelvipfb_drm_connector_funcs = {
> > +	.reset = drm_atomic_helper_connector_reset,
> > +	.detect = intelvipfb_drm_connector_detect,
> > +	.fill_modes = drm_helper_probe_single_connector_modes,
> > +	.destroy = intelvipfb_drm_connector_destroy,
> > +	.atomic_destroy_state =
> > drm_atomic_helper_connector_destroy_state,
> > +};
> > +
> > +static int intelvipfb_drm_connector_get_modes(struct drm_connector
> > *connector)
> > +{
> > +	struct drm_device *drm = connector->dev;
> > +	int count;
> > +
> > +	count = drm_add_modes_noedid(connector, drm-
> > >mode_config.max_width,
> > +				ÂÂÂÂÂdrm->mode_config.max_height);
> > +	drm_set_preferred_mode(connector, drm-
> > >mode_config.max_width,
> > +			ÂÂÂÂÂÂÂdrm->mode_config.max_height);
> > +	return count;
> > +}
> > +
> > +static const struct drm_connector_helper_funcs
> > +intelvipfb_drm_connector_helper_funcs = {
> > +	.get_modes = intelvipfb_drm_connector_get_modes,
> > +};
> > +
> > +struct drm_connector *
> > +intelvipfb_conn_setup(struct drm_device *drm)
> > +{
> > +	struct drm_connector *conn;
> > +	int ret;
> > +
> > +	conn = devm_kzalloc(drm->dev, sizeof(*conn), GFP_KERNEL);
> > +	if (IS_ERR(conn))
> > +		return NULL;
> > +
> > +	ret = drm_connector_init(drm, conn,
> > &intelvipfb_drm_connector_funcs,
> > +				ÂDRM_MODE_CONNECTOR_DisplayPort);
> > +	if (ret < 0) {
> > +		dev_err(drm->dev, "failed to initialize drm
> > connector\n");
> > +		ret = -ENOMEM;
> > +		goto error_connector_cleanup;
> > +	}
> > +
> > +	conn->polled = 0;
> No need to set this, it is already zero from the allocation.
> 
> > 
> > +	drm_connector_helper_add(conn,
> > &intelvipfb_drm_connector_helper_funcs);
> > +
> > +	return conn;
> > +
> > +error_connector_cleanup:
> > +	drm_connector_cleanup(conn);
> > +
> > +	return NULL;
> > +}
> > diff --git a/drivers/gpu/drm/ivip/intel_vip_core.c
> > b/drivers/gpu/drm/ivip/intel_vip_core.c
> > new file mode 100644
> > index 0000000..b601bb4
> > --- /dev/null
> > +++ b/drivers/gpu/drm/ivip/intel_vip_core.c
> > @@ -0,0 +1,160 @@
> > +/*
> > + * intel_vip_core.c -- Intel Video and Image Processing(VIP)
> > + * Frame Buffer II driver
> > + *
> > + * This driver supports the Intel VIP Frame Reader component.
> > + * More info on the hardware can be found in the Intel Video
> > + * and Image Processing Suite User Guide at this address
> > + * http://www.altera.com/literature/ug/ug_vip.pdf.
> > + *
> > + * This program is free software; you can redistribute it and/or
> > modify it
> > + * under the terms and conditions of the GNU General Public
> > License,
> > + * version 2, as published by the Free Software Foundation.
> > + *
> > + * This program is distributed in the hope it will be useful, but
> > WITHOUT
> > + * ANY WARRANTY; without even the implied warranty of
> > MERCHANTABILITY or
> > + * FITNESS FOR A PARTICULAR PURPOSE.ÂÂSee the GNU General Public
> > License for
> > + * more details.
> > + *
> > + * Authors:
> > + * Ong, Hean-Loong <hean.loong.ong@xxxxxxxxx>
> > + *
> > + */
> > +
> > +#include <drm/drmP.h>
> > +#include <drm/drm_atomic.h>
> > +#include <drm/drm_atomic_helper.h>
> > +#include <drm/drm_crtc_helper.h>
> > +#include <drm/drm_fb_helper.h>
> > +#include <drm/drm_fb_cma_helper.h>
> > +#include <drm/drm_gem_cma_helper.h>
> > +#include <drm/drm_plane_helper.h>
> > +#include <drm/drm_simple_kms_helper.h>
> > +#include <drm/drm_gem_framebuffer_helper.h>
> > +
> > +#include <linux/init.h>
> > +#include <linux/kernel.h>
> > +#include <linux/module.h>
> > +
> > +#include "intel_vip_drv.h"
> > +
> > +static void intelvipfb_enable(struct drm_simple_display_pipe
> > *pipe,
> > +			ÂÂÂÂÂÂstruct drm_crtc_state *crtc_state,
> > struct drm_plane_state *plane_state)
> > +{
> > +	/*
> > +	Â* The frameinfo variable has to correspond to the size of
> > the VIP Suite
> > +	Â* Frame Reader register 7 which will determine the
> > maximum size used
> > +	Â* in this frameinfo
> > +	Â*/
> > +
> > +	u32 frameinfo;
> > +	struct intelvipfb_priv *priv = pipe->plane.dev-
> > >dev_private;
> > +	void __iomem *base = priv->base;
> > +	struct drm_plane_state *state = pipe->plane.state;
> > +	dma_addr_t addr;
> > +
> > +	addr = drm_fb_cma_get_gem_addr(state->fb, state, 0);
> > +
> > +	frameinfo =
> > +		readl(base + INTELVIPFB_FRAME_READER) &
> > 0x00ffffff;
> > +	writel(frameinfo, base + INTELVIPFB_FRAME_INFO);
> > +	writel(addr, base + INTELVIPFB_FRAME_START);
> > +	/* Finally set the control register to 1 to start
> > streaming */
> > +	writel(1, base + INTELVIPFB_CONTROL);
> > +}
> > +
> > +static void intelvipfb_disable(struct drm_simple_display_pipe
> > *pipe)
> > +{
> > +	struct intelvipfb_priv *priv = pipe->plane.dev-
> > >dev_private;
> > +	void __iomem *base = priv->base;
> > +	/* set the control register to 0 to stop streaming */
> > +	writel(0, base + INTELVIPFB_CONTROL);
> > +}
> > +
> > +static const struct drm_mode_config_funcs
> > intelvipfb_mode_config_funcs = {
> > +	.fb_create = drm_gem_fb_create,
> > +	.atomic_check = drm_atomic_helper_check,
> > +	.atomic_commit = drm_atomic_helper_commit,
> > +};
> > +
> > +static void intelvipfb_setup_mode_config(struct drm_device *drm)
> > +{
> > +	drm_mode_config_init(drm);
> > +	drm->mode_config.funcs = &intelvipfb_mode_config_funcs;
> > +}
> > +
> > +static int intelvipfb_pipe_prepare_fb(struct
> > drm_simple_display_pipe *pipe,
> > +				ÂÂÂÂÂÂstruct drm_plane_state
> > *plane_state)
> > +{
> > +	return drm_gem_fb_prepare_fb(&pipe->plane, plane_state);
> > +}
> > +
> > +static struct drm_simple_display_pipe_funcs fbpriv_funcs = {
> > +	.prepare_fb = intelvipfb_pipe_prepare_fb,
> You can use drm_gem_fb_simple_display_pipe_prepare_fb(), no need to
> roll
> your own.
> 
> > 
> > +	.enable = intelvipfb_enable,
> > +	.disable = intelvipfb_disable
> > +};
> > +
> > +int intelvipfb_probe(struct device *dev)
> > +{
> > +	int retval;
> > +	struct drm_device *drm;
> > +	struct intelvipfb_priv *fbpriv = dev_get_drvdata(dev);
> > +	struct drm_connector *connector;
> > +	u32 formats[] = {DRM_FORMAT_XRGB8888};
> > +
> > +	drm = fbpriv->drm;
> > +
> > +	drm->dev_private = fbpriv;
> > +
> > +	intelvipfb_setup_mode_config(drm);
> > +
> > +	connector = intelvipfb_conn_setup(drm);
> > +	if (!connector) {
> > +		dev_err(drm->dev, "Connector setup failed\n");
> > +		goto err_mode_config;
> > +	}
> > +
> > +	retval = drm_simple_display_pipe_init(drm, &fbpriv->pipe,
> > +					ÂÂÂÂÂÂ&fbpriv_funcs,
> > formats,
> > +			ARRAY_SIZE(formats), NULL, connector);
> > +	if (retval < 0) {
> > +		dev_err(drm->dev, "Cannot setup simple display
> > pipe\n");
> > +		goto err_mode_config;
> > +	}
> > +
> > +	fbpriv->fbcma = drm_fbdev_cma_init(drm,
> > +			drm->mode_config.preferred_depth,
> > +			drm->mode_config.num_connector);
> Please use drm_fbdev_generic_setup() for fbdev emulation. It tears
> down
> automatically on drm_dev_unregister() and you don't need the
> drm_driver->lastclose hook.
> 
> All drivers that use drm_fbdev_cma_init() will move to this shortly.
> 
> Noralf.
> 
I could not find any examples that currently uses
theÂdrm_fbdev_generic_setup (). Would you mind pointing me on where
such examples are available that would allow me to replace the
assignment of the fbcma pointer withÂdrm_fbdev_generic_setup() method

Thanks.
Hean Loong.

> > 
> > +
> > +	drm_mode_config_reset(drm);
> > +
> > +	drm_dev_register(drm, 0);
> > +
> > +	return retval;
> > +
> > +err_mode_config:
> > +
> > +	drm_mode_config_cleanup(drm);
> > +	return -ENODEV;
> > +}
> > +
> > +int intelvipfb_remove(struct device *dev)
> > +{
> > +	struct intelvipfb_priv *fbpriv = dev_get_drvdata(dev);
> > +	struct drm_device *drm =ÂÂfbpriv->drm;
> > +
> > +	drm_dev_unregister(drm);
> > +
> > +	if (fbpriv->fbcma)
> > +		drm_fbdev_cma_fini(fbpriv->fbcma);
> > +
> > +	drm_mode_config_cleanup(drm);
> > +	drm_dev_unref(drm);
> > +
> > +	return 0;
> > +}
> > +
> > +MODULE_AUTHOR("Ong, Hean-Loong <hean.loong.ong@xxxxxxxxx>");
> > +MODULE_DESCRIPTION("Intel VIP Frame Buffer II driver");
> > +MODULE_LICENSE("GPL v2");
> > diff --git a/drivers/gpu/drm/ivip/intel_vip_drv.h
> > b/drivers/gpu/drm/ivip/intel_vip_drv.h
> > new file mode 100644
> > index 0000000..0a3555d
> > --- /dev/null
> > +++ b/drivers/gpu/drm/ivip/intel_vip_drv.h
> > @@ -0,0 +1,52 @@
> > +/*
> > + * Copyright (C) 2017 Intel Corporation.
> > + *
> > + * Intel Video and Image Processing(VIP) Frame Buffer II driver.
> > + *
> > + * This program is free software; you can redistribute it and/or
> > modify it
> > + * under the terms and conditions of the GNU General Public
> > License,
> > + * version 2, as published by the Free Software Foundation.
> > + *
> > + * This program is distributed in the hope it will be useful, but
> > WITHOUT
> > + * ANY WARRANTY; without even the implied warranty of
> > MERCHANTABILITY or
> > + * FITNESS FOR A PARTICULAR PURPOSE.ÂÂSee the GNU General Public
> > License for
> > + * more details.
> > + *
> > + * You should have received a copy of the GNU General Public
> > License along with
> > + * this program.ÂÂIf not, see <http://www.gnu.org/licenses/>.
> > + *
> > + * Authors:
> > + * Ong, Hean-Loong <hean.loong.ong@xxxxxxxxx>
> > + *
> > + */
> > +#ifndef _INTEL_VIP_DRV_H
> > +#define _INTEL_VIP_DRV_H
> > +
> > +#define DRIVER_NAMEÂÂÂÂ"intelvipfb"
> > +#define BYTES_PER_PIXEL	Â4
> > +#define CRTC_NUM	ÂÂÂÂÂÂÂÂ1
> > +#define CONN_NUM	ÂÂÂÂÂÂÂÂ1
> > +
> > +/* control registers */
> > +#define INTELVIPFB_CONTROL	ÂÂÂÂÂÂ0
> > +#define INTELVIPFB_STATUS	ÂÂÂÂÂÂÂ0x4
> > +#define INTELVIPFB_INTERRUPT	ÂÂÂÂ0x8
> > +#define INTELVIPFB_FRAME_COUNTER	0xC
> > +#define INTELVIPFB_FRAME_DROP	ÂÂÂ0x10
> > +#define INTELVIPFB_FRAME_INFO	ÂÂÂ0x14
> > +#define INTELVIPFB_FRAME_START	ÂÂ0x18
> > +#define INTELVIPFB_FRAME_READER	ÂÂÂÂÂÂÂÂÂ0x1C
> > +
> > +int intelvipfb_probe(struct device *dev);
> > +int intelvipfb_remove(struct device *dev);
> > +int intelvipfb_setup_crtc(struct drm_device *drm);
> > +struct drm_connector *intelvipfb_conn_setup(struct drm_device
> > *drm);
> > +
> > +struct intelvipfb_priv {
> > +	struct drm_simple_display_pipe pipe;
> > +	struct drm_fbdev_cma *fbcma;
> > +	struct drm_device *drm;
> > +	voidÂÂÂÂ__iomem *base;
> > +};
> > +
> > +#endif
> > diff --git a/drivers/gpu/drm/ivip/intel_vip_of.c
> > b/drivers/gpu/drm/ivip/intel_vip_of.c
> > new file mode 100644
> > index 0000000..47302f9
> > --- /dev/null
> > +++ b/drivers/gpu/drm/ivip/intel_vip_of.c
> > @@ -0,0 +1,193 @@
> > +/*
> > + * intel_vip_of.c -- Intel Video and Image Processing(VIP)
> > + * Frame Buffer II driver
> > + *
> > + * This driver supports the Intel VIP Frame Reader component.
> > + * More info on the hardware can be found in the Intel Video
> > + * and Image Processing Suite User Guide at this address
> > + * http://www.altera.com/literature/ug/ug_vip.pdf.
> > + *
> > + * This program is free software; you can redistribute it and/or
> > modify it
> > + * under the terms and conditions of the GNU General Public
> > License,
> > + * version 2, as published by the Free Software Foundation.
> > + *
> > + * This program is distributed in the hope it will be useful, but
> > WITHOUT
> > + * ANY WARRANTY; without even the implied warranty of
> > MERCHANTABILITY or
> > + * FITNESS FOR A PARTICULAR PURPOSE.ÂÂSee the GNU General Public
> > License for
> > + * more details.
> > + *
> > + * Authors:
> > + * Ong, Hean-Loong <hean.loong.ong@xxxxxxxxx>
> > + *
> > + */
> > +#include <drm/drm_fb_helper.h>
> > +#include <drm/drm_fb_cma_helper.h>
> > +#include <drm/drm_gem_cma_helper.h>
> > +#include <drm/drm_of.h>
> > +#include <drm/drm_simple_kms_helper.h>
> > +
> > +#include <linux/component.h>
> > +#include <linux/init.h>
> > +#include <linux/kernel.h>
> > +#include <linux/module.h>
> > +#include <linux/platform_device.h>
> > +
> > +#include "intel_vip_drv.h"
> > +
> > +DEFINE_DRM_GEM_CMA_FOPS(drm_fops);
> > +
> > +static void intelvipfb_lastclose(struct drm_device *drm)
> > +{
> > +	struct intelvipfb_priv *priv = drm->dev_private;
> > +
> > +	drm_fbdev_cma_restore_mode(priv->fbcma);
> > +}
> > +
> > +static struct drm_driver intelvipfb_drm = {
> > +	.driver_features =
> > +			DRIVER_MODESET | DRIVER_GEM |
> > +			DRIVER_PRIME | DRIVER_ATOMIC,
> > +	.gem_free_object_unlocked = drm_gem_cma_free_object,
> > +	.gem_vm_ops = &drm_gem_cma_vm_ops,
> > +	.dumb_create = drm_gem_cma_dumb_create,
> > +	.dumb_destroy = drm_gem_dumb_destroy,
> > +	.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> > +	.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> > +	.gem_prime_export = drm_gem_prime_export,
> > +	.gem_prime_import = drm_gem_prime_import,
> > +	.gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
> > +	.gem_prime_import_sg_table =
> > drm_gem_cma_prime_import_sg_table,
> > +	.gem_prime_vmap = drm_gem_cma_prime_vmap,
> > +	.gem_prime_vunmap = drm_gem_cma_prime_vunmap,
> > +	.gem_prime_mmap = drm_gem_cma_prime_mmap,
> > +	.lastclose = intelvipfb_lastclose,
> > +	.name = DRIVER_NAME,
> > +	.date = "20170729",
> > +	.desc = "Intel FPGA VIP SUITE",
> > +	.major = 1,
> > +	.minor = 0,
> > +	.ioctls = NULL,
> > +	.patchlevel = 0,
> > +	.fops = &drm_fops,
> > +};
> > +
> > +/*
> > + * Setting up information derived from OF Device Tree Nodes
> > + * max-width, max-height, bits per pixel, memory port width
> > + */
> > +
> > +static int intelvipfb_drm_setup(struct device *dev,
> > +				struct intelvipfb_priv *fbpriv)
> > +{
> > +	struct drm_device *drm = fbpriv->drm;
> > +	struct device_node *np = dev->of_node;
> > +	int mem_word_width;
> > +	int max_h, max_w;
> > +	int ret;
> > +
> > +	ret = of_property_read_u32(np, "altr,max-width", &max_w);
> > +	if (ret) {
> > +		dev_err(dev,
> > +			"Missing required parameter 'altr,max-
> > width'");
> > +		return ret;
> > +	}
> > +
> > +	ret = of_property_read_u32(np, "altr,max-height", &max_h);
> > +	if (ret) {
> > +		dev_err(dev,
> > +			"Missing required parameter 'altr,max-
> > height'");
> > +		return ret;
> > +	}
> > +
> > +	ret = of_property_read_u32(np, "altr,mem-port-width",
> > &mem_word_width);
> > +	if (ret) {
> > +		dev_err(dev, "Missing required parameter
> > 'altr,mem-port-width '");
> > +		return ret;
> > +	}
> > +
> > +	if (!(mem_word_width >= 32 && mem_word_width % 32 == 0)) {
> > +		dev_err(dev,
> > +			"mem-word-width is set to %i. must be >=
> > 32 and multiple of 32.",
> > +			Âmem_word_width);
> > +		return -ENODEV;
> > +	}
> > +
> > +	drm->mode_config.min_width = 640;
> > +	drm->mode_config.min_height = 480;
> > +	drm->mode_config.max_width = max_w;
> > +	drm->mode_config.max_height = max_h;
> > +	drm->mode_config.preferred_depth = 32;
> > +
> > +	return 0;
> > +}
> > +
> > +static int intelvipfb_of_probe(struct platform_device *pdev)
> > +{
> > +	int retval;
> > +	struct resource *reg_res;
> > +	struct intelvipfb_priv *fbpriv;
> > +	struct device *dev = &pdev->dev;
> > +	struct drm_device *drm;
> > +
> > +	fbpriv = devm_kzalloc(dev, sizeof(*fbpriv), GFP_KERNEL);
> > +	if (!fbpriv)
> > +		return -ENOMEM;
> > +
> > +	/*setup DRM */
> > +	drm = drm_dev_alloc(&intelvipfb_drm, dev);
> > +	if (IS_ERR(drm))
> > +		return PTR_ERR(drm);
> > +
> > +	retval = dma_set_mask_and_coherent(drm->dev,
> > DMA_BIT_MASK(32));
> > +	if (retval)
> > +		return -ENODEV;
> > +
> > +	fbpriv->drm = drm;
> > +
> > +	reg_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > +	if (!reg_res)
> > +		return -ENOMEM;
> > +
> > +	fbpriv->base = devm_ioremap_resource(dev, reg_res);
> > +
> > +	if (IS_ERR(fbpriv->base)) {
> > +		dev_err(dev, "devm_ioremap_resource failed\n");
> > +		retval = PTR_ERR(fbpriv->base);
> > +		return -ENOMEM;
> > +	}
> > +
> > +	intelvipfb_drm_setup(dev, fbpriv);
> > +
> > +	dev_set_drvdata(dev, fbpriv);
> > +
> > +	return intelvipfb_probe(dev);
> > +}
> > +
> > +static int intelvipfb_of_remove(struct platform_device *pdev)
> > +{
> > +	return intelvipfb_remove(&pdev->dev);
> > +}
> > +
> > +/*
> > + * The name vip-frame-buffer-2.0 is derived from
> > + * http://www.altera.com/literature/ug/ug_vip.pdf
> > + * frame buffer IP cores section 14
> > + */
> > +
> > +static const struct of_device_id intelvipfb_of_match[] = {
> > +	{ .compatible = "altr,vip-frame-buffer-2.0" },
> > +	{},
> > +};
> > +
> > +MODULE_DEVICE_TABLE(of, intelvipfb_of_match);
> > +
> > +static struct platform_driver intelvipfb_driver = {
> > +	.probe = intelvipfb_of_probe,
> > +	.remove = intelvipfb_of_remove,
> > +	.driver = {
> > +		.name = DRIVER_NAME,
> > +		.of_match_table = intelvipfb_of_match,
> > +	},
> > +};
> > +
> > +module_platform_driver(intelvipfb_driver);