Re: [PATCH] kdb: kdb_main: refactor code in kdb_md_line

[Gustavo A. R. Silva]

On 8/16/18 4:32 AM, Daniel Thompson wrote:

>> diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
>> index 2ddfce8..4b896a6 100644
>> --- a/kernel/debug/kdb/kdb_main.c
>> +++ b/kernel/debug/kdb/kdb_main.c
>> @@ -1538,25 +1538,9 @@ static void kdb_md_line(const char *fmtstr, unsigned long addr,
>>  			wc.word = word;
>>  #define printable_char(c) \
>>  	({unsigned char __c = c; isascii(__c) && isprint(__c) ? __c : '.'; })
>> -			switch (bytesperword) {
>> -			case 8:
>> +			for (i = 0; i < bytesperword; i++)
> 
> i already a control variable for the outer loop. It is not safe to reuse
> it here.
> 

Oh I see. I'll send v2 shortly.

Thanks
--
Gustavo