Re: [PATCH v3 4/4] mm/memory_hotplug: Drop node_online check in unregister_mem_sect_under_nodes

[David Hildenbrand]

On 15.08.2018 16:42, Oscar Salvador wrote:
> From: Oscar Salvador <osalvador@xxxxxxx>
> 
> We are getting the nid from the pages that are not yet removed,
> but a node can only be offline when its memory/cpu's have been removed.
> Therefore, we know that the node is still online.
> 
> Signed-off-by: Oscar Salvador <osalvador@xxxxxxx>
> ---
>  drivers/base/node.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/base/node.c b/drivers/base/node.c
> index 81b27b5b1f15..b23769e4fcbb 100644
> --- a/drivers/base/node.c
> +++ b/drivers/base/node.c
> @@ -465,8 +465,6 @@ void unregister_mem_sect_under_nodes(struct memory_block *mem_blk,
>  
>  		if (nid < 0)
>  			continue;
> -		if (!node_online(nid))
> -			continue;
>  		/*
>  		 * It is possible that NODEMASK_ALLOC fails due to memory
>  		 * pressure.
> 

Sounds reasonable to me

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

-- 

Thanks,

David / dhildenb