Re: [PATCH V2] EDAC, amd64: Add Family 17h Model 10h support.

[Michael Jin]

On Thu, Aug 16, 2018 at 2:17 PM, Ghannam, Yazen <Yazen.Ghannam@xxxxxxx> wrote:
>> -----Original Message-----
>> From: Michael Jin <mikhail.jin@xxxxxxxxx>
>> Sent: Wednesday, August 15, 2018 6:41 AM
>> To: Borislav Petkov <bp@xxxxxxx>; Ghannam, Yazen
>> <Yazen.Ghannam@xxxxxxx>; Mauro Carvalho Chehab
>> <mchehab@xxxxxxxxxx>
>> Cc: linux-edac@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Michael Jin
>> <mikhail.jin@xxxxxxxxx>; stable@xxxxxxxxxxxxxxx
>> Subject: [PATCH V2] EDAC, amd64: Add Family 17h Model 10h support.
>>
>> Add support for ECC error decoding on family 17h models 10h-2fh.
>>
>
> Can you please make this more specific? Something like "Add PCI device IDs
> for Fam17h Models 10h-2Fh so that amd64_edac_mod will load".

I have submitted patch v3 with a commit message that is more specific.

>>       case 0x17:
>> +             /* Check if CPU model is in range 10h-2fh */
>
> This comment is not needed because it's obvious from the code.

The comment in patch v2 has been removed in patch v3.

Thanks,
Michael