Re: [PATCH 1/4] regulator: core: If consumers don't call regulator_set_load() assume max

From: David Collins
Date: Thu Aug 16 2018 - 16:58:15 EST


Hello Doug,

On 08/16/2018 01:07 PM, Doug Anderson wrote:
> I'll work on either adding more regulator_set_load() calls to clients
> or perhaps disabling the "regulator-allow-set-load" for a bunch of
> rails. David: presumably if we have a rail that we never need to be
> on-and-in-low-power-mode can just be left in high power mode all the
> time? There should be no advantage of being in low power mode for a
> regulator that is off, right?

Generally speaking, yes, that is true on both points. The only caveat is
that there could be a minor power penalty if APPS votes for OFF+HPM and a
non-HLOS processor votes for ON+LPM for the same regulator. This would
lead to an aggregated state of ON+HPM when only ON+LPM is really needed.

Take care,
David

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project