Re: [PATCH 2/2] drm/amd/display: Don't build DCN1 when kcov is enabled

From: Arnd Bergmann
Date: Thu Aug 16 2018 - 17:06:11 EST


On Thu, Aug 16, 2018 at 9:45 PM <sunpeng.li@xxxxxxx> wrote:
>
> From: "Leo (Sunpeng) Li" <sunpeng.li@xxxxxxx>
>
> DCN1 contains code that utilizes fp math. When
> CONFIG_KCOV_INSTRUMENT_ALL and CONFIG_KCOV_ENABLE_COMPARISONS are
> enabled, build errors are found. See this earlier patch for details:
>
> https://lists.freedesktop.org/archives/dri-devel/2018-August/186131.html
>
> As a short term solution, disable CONFIG_DRM_AMD_DC_DCN1_0 when
> KCOV_INSTRUMENT_ALL and KCOV_ENABLE_COMPARISONS are enabled. In
> addition, make it a fully derived config, taking into account
> CONFIG_X86.
>
> Signed-off-by: Leo (Sunpeng) Li <sunpeng.li@xxxxxxx>

Looks good to me,

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>