Re: [PATCH 1/2] PCI/DPC: Add 'nodpc' parameter

From: Derrick, Jonathan
Date: Thu Aug 16 2018 - 17:28:51 EST


On Thu, 2018-08-16 at 15:19 -0600, Keith Busch wrote:
> On Thu, Aug 16, 2018 at 01:50:42PM -0700, Derrick, Jonathan wrote:
> > It can also be disabled with setpci, but is that any less of a
> > hassle?
> > Genuine question to understand your point of view.
>
> That is not a real solution, IMO. 'setpci' is good to inject things
> for testing, but it changes config space without the kernel aware
> that
> you've done that, so it is inherently racey with other kernel threads
> touching pci config space. And the kernel or platform may end up
> undoing
> what you had 'setpci' do anyway with no immediate way to be notified
> it
> was changed.

It sounds like a sysfs toggle could be useful regardless of the boot
parameter.

Attachment: smime.p7s
Description: S/MIME cryptographic signature