Re: [PATCH 1/2] x86: apm: mark proc_apm_show as __maybe_unused

[Christoph Hellwig]

On Tue, Aug 14, 2018 at 11:18:45AM +0200, Arnd Bergmann wrote:
> A new build error appeared with CONFIG_PROC_FS disabled:
> 
> arch/x86/kernel/apm_32.c:1643:12: error: 'proc_apm_show' defined but not used [-Werror=unused-function]
> 
> This marks the function as __maybe_unused to let the compiler drop
> it silently.
> 
> Fixes: 3f3942aca6da ("proc: introduce proc_create_single{,_data}")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

I have to admit I actually prefer ifdefs over magic __maybe_unused
annotations.  But otherwise this looks correct to me, same for the
other patch.