Re: [RFC] etnaviv: missing dma_mask

From: Christoph Hellwig
Date: Fri Aug 17 2018 - 02:42:45 EST


On Tue, Aug 14, 2018 at 05:12:25PM +0300, Eugeniy Paltsev wrote:
> Hi Lucas, Christoph,
>
> After switching ARC to generic dma_noncoherent cache ops
> etnaviv driver start failing on dma maping functions because of
> dma_mask lack.
>
> So I'm wondering is it valid case to have device which is
> DMA capable and doesn't have dma_mask set?
>
> If not, then I guess something like that should work
> (at least it works for ARC):

This looks ok is a minimal fix:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

But why doesn't this device have a dma-range property in DT?