Re: [PATCH] platform/x86: fix intel_punit_ipc.c build errors

From: Andy Shevchenko
Date: Fri Aug 17 2018 - 07:00:06 EST


On Wed, Aug 15, 2018 at 7:12 PM, Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> Fix build errors by #including <linux/io.h>.
>
> ../drivers/platform/x86/intel_punit_ipc.c: In function 'ipc_read_status':
> ../drivers/platform/x86/intel_punit_ipc.c:55:2: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
> return readl(ipcdev->base[type][BASE_IFACE]);
> ../drivers/platform/x86/intel_punit_ipc.c: In function 'ipc_write_cmd':
> ../drivers/platform/x86/intel_punit_ipc.c:60:2: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration]
> writel(cmd, ipcdev->base[type][BASE_IFACE]);
>

Thanks, pushed to our for-next queue, with Fixes tag appended.

> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Zha Qipeng <qipeng.zha@xxxxxxxxx>
> Cc: platform-driver-x86@xxxxxxxxxxxxxxx
> ---
> Found in linux-next but applies to current mainline also.
>
> drivers/platform/x86/intel_punit_ipc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20180815.orig/drivers/platform/x86/intel_punit_ipc.c
> +++ linux-next-20180815/drivers/platform/x86/intel_punit_ipc.c
> @@ -18,6 +18,7 @@
> #include <linux/bitops.h>
> #include <linux/device.h>
> #include <linux/interrupt.h>
> +#include <linux/io.h>
> #include <linux/platform_device.h>
> #include <asm/intel_punit_ipc.h>
>
>
>



--
With Best Regards,
Andy Shevchenko