Re: [PATCH] gpio: 74x164: add lines-initial-states property

From: Rob Herring
Date: Fri Aug 17 2018 - 11:10:10 EST


Hi, this email is from Rob's (experimental) review bot. I found a couple
of common problems with your patch. Please see below.

On Wed, 15 Aug 2018 22:18:54 +0200, David Bauer wrote:
> This adds the ability to define the initial state of each output line on
> device probe.
>
> Signed-off-by: David Bauer <mail@xxxxxxxxxxxxxxx>

The preferred subject prefix is "dt-bindings: <binding dir>: ...".

> ---
> Documentation/devicetree/bindings/gpio/gpio-74x164.txt | 5 +++++
> drivers/gpio/gpio-74x164.c | 3 +++
> 2 files changed, 8 insertions(+)
>

DT bindings (including binding headers) should be a separate patch. See
Documentation/devicetree/bindings/submitting-patches.txt.