Re: [PATCH] kernel: Add spaces around '=' operator

From: Greg KH
Date: Fri Aug 17 2018 - 12:19:38 EST


On Fri, Aug 17, 2018 at 06:53:48PM +0530, Bhaskar Singh wrote:
> This patch fixes the checkpatch.pl ERROR:
>
> ERROR: spaces required around that '==' (ctx:VxV)
>
> Signed-off-by: Bhaskar Singh <bhaskar.kernel@xxxxxxxxx>
> ---
> kernel/acct.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/acct.c b/kernel/acct.c
> index addf7732fb56..6dc0a55b575c 100644
> --- a/kernel/acct.c
> +++ b/kernel/acct.c
> @@ -449,7 +449,7 @@ static void fill_ac(acct_t *ac)
> #endif
> do_div(elapsed, AHZ);
> ac->ac_btime = get_seconds() - elapsed;
> -#if ACCT_VERSION==2
> +#if ACCT_VERSION == 2

checkpatch is a guide, not a fast rule, and might not matter here.

Please stick to checkpatch fixes in drivers/staging/ only, not any other
part of the kernel unless you know the maintainer accepts such patches.

thanks,

greg k-h