Re: [PATCH v3 6/9] dt-bindings: iio: tsl2772: add bindings for regulator framework

[Jonathan Cameron]

On Tue, 7 Aug 2018 11:20:28 -0600
Rob Herring <robh@xxxxxxxxxx> wrote:

> On Fri, Aug 03, 2018 at 10:51:23PM +0100, Jonathan Cameron wrote:
> > On Thu,  2 Aug 2018 20:18:57 -0400
> > Brian Masney <masneyb@xxxxxxxxxxxxx> wrote:
> >   
> > > This patch adds device tree bindings to the tsl2772 driver for the
> > > regulator framework.
> > > 
> > > Signed-off-by: Brian Masney <masneyb@xxxxxxxxxxxxx>  
> > I suspect Rob will tell you this should really have been in the same
> > patch as the earlier bindings.   There is no need for us to wait
> > for the driver support as the binding describes what is there, not
> > what we do with it.  
> 
> Yep.
> 
> > 
> > Otherwise it's fine and if nothing else comes up I can merge them ;)

I merged them.

Jonathan
> > 
> > Jonathan
> >   
> > > ---
> > >  Documentation/devicetree/bindings/iio/light/tsl2772.txt | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/iio/light/tsl2772.txt b/Documentation/devicetree/bindings/iio/light/tsl2772.txt
> > > index 6f33169344f2..4e7d98627cbf 100644
> > > --- a/Documentation/devicetree/bindings/iio/light/tsl2772.txt
> > > +++ b/Documentation/devicetree/bindings/iio/light/tsl2772.txt
> > > @@ -21,6 +21,8 @@ Optional properties:
> > >                                 are the only valid values.
> > >    - led-max-microamp - current for the proximity LED. Must be 100000, 50000,
> > >                         25000, or 13000.
> > > +  - vdd-supply: phandle to the regulator that provides power to the sensor.
> > > +  - vddio-supply: phandle to the regulator that provides power to the bus.
> > >    - interrupts: the sole interrupt generated by the device
> > >  
> > >    Refer to interrupt-controller/interrupts.txt for generic interrupt client
> > > @@ -32,6 +34,8 @@ tsl2772@39 {
> > >  	compatible = "amstaos,tsl2772";
> > >  	reg = <0x39>;
> > >  	interrupts-extended = <&msmgpio 61 IRQ_TYPE_EDGE_FALLING>;
> > > +	vdd-supply = <&pm8941_l17>;
> > > +	vddio-supply = <&pm8941_lvs1>;
> > >  	amstaos,proximity-diodes = <0>;
> > >  	led-max-microamp = <100000>;
> > >  };  
> >