Re: [PATCH] x86/process: Export start_thread()

From: Andy Lutomirski
Date: Mon Aug 20 2018 - 10:27:15 EST




> On Aug 20, 2018, at 12:30 AM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>
> On Sun, 19 Aug 2018, Andy Lutomirski wrote:
>>> On Aug 19, 2018, at 4:08 PM, Rian Hunter <rian@xxxxxxxxxxxx> wrote:
>>>
>>> Commit e634d8fc792c ("x86-64: merge the standard and compat
>>> start_thread() functions") removed exporting for the start_thread()
>>> function in what seems like a typo. Add it back to
>>> arch/x86/kernel/process_64.c for parity with process_32.c and other
>>> arch.
>>
>> What for? Perhaps 32-bit could remove it instead?
>
> No. start_thread() is called from various binfmt implementations which can
> be built as modules.

Fair enough. Iâm fine with the patch.

>
> Thanks,
>
> tglx