Re: [PATCH v2] fpga: dfl: region: Restory symmetry in probe()/remove()
From: Moritz Fischer
Date: Mon Aug 20 2018 - 13:54:12 EST
Hi Alan,
On Mon, Aug 20, 2018 at 12:46:32PM -0500, Alan Tull wrote:
> On Mon, Aug 20, 2018 at 12:18 PM, Moritz Fischer <mdf@xxxxxxxxxx> wrote:
>
> Hi Moritz,
>
> > Replace dev_get_drvdata() with platform_get_drvdata() to
> > match the platform_set_drvdata() in the probe function of
> > the platform driver.
> >
> > Fixes commit bb61b9be3e6b ("fpga: dfl: add fpga region platform driver for FME")
> > Signed-off-by: Moritz Fischer <mdf@xxxxxxxxxx>
> > ---
> >
> > Changes from v1:
> > - Still compile after change ...
> >
> > ---
> > drivers/fpga/dfl-fme-region.c | 2 +-
>
> Thanks for catching this. of-fpga-region.c does a similar thing and
> needs s/dev_set_drvdata/platform_set_drvdata/ in the probe. Could you
> fix it here too?
Yeah, can do in a v3 series ... Will add your Suggested-by: ...
Cheers,
Moritz