Re: [PATCH] scripts/dtc: consolidate include path options in Makefile

From: Rob Herring
Date: Mon Aug 20 2018 - 17:30:33 EST


On Mon, Aug 20, 2018 at 1:56 AM Masahiro Yamada
<yamada.masahiro@xxxxxxxxxxxxx> wrote:
>
> Hi Rob,
>
>
> 2018-07-04 10:59 GMT+09:00 Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>:
> > It is tedious to specify extra compiler options for every file.
> > HOST_EXTRACFLAGS is useful to add options to all files in a
> > directory.
> >
> > -I$(src)/libfdt is needed for all the files in this directory
> > to include libfdt_env.h etc. from scripts/dtc/libfdt/.
> >
> > On the other hand, -I$(src) is used to include check-in headers
> > from generated C files. Thus, I added it only to dtc-lexer.lex.o
> > and dtc-parser.tab.o .
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
>
>
> I hope this is a good clean-up.

Sorry, I missed this.

> May I apply this to my kbuild tree for v4.19 ?

Yes.

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>