Re: [PATCH] percpu: cleanup PER_CPU_DEF_ATTRIBUTES macro

From: Tejun Heo
Date: Tue Aug 21 2018 - 11:56:17 EST


Hello,

On Tue, Aug 21, 2018 at 04:40:30PM +0300, Alexander Pateenok wrote:
> The macro is not used:
>
> $ grep -r PER_CPU_DEF_ATTRIBUTES
> include/linux/percpu-defs.h: __PCPU_ATTRS(sec) PER_CPU_DEF_ATTRIBUTES __weak \
> include/linux/percpu-defs.h: __PCPU_ATTRS(sec) PER_CPU_DEF_ATTRIBUTES \
> include/asm-generic/percpu.h:#ifndef PER_CPU_DEF_ATTRIBUTES
> include/asm-generic/percpu.h:#define PER_CPU_DEF_ATTRIBUTES
>
> It was added with b01e8dc34379 ("alpha: fix percpu build breakage") and
> removed in 2009 with b01e8dc34379..6088464cf1ae.
>
> Signed-off-by: Alexander Pateenok <pateenoc@xxxxxxxxx>

I'm not sure this is a meaningful cleanup, but then again, why not?
Can you please repost the patch to Andrew so that it can go through
-mm tree? Please feel free to add

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks.

--
tejun