Re: [PATCH] libbpf: Remove the duplicate checking of function storage

From: Taeung Song
Date: Tue Aug 21 2018 - 22:54:40 EST




On 08/22/2018 05:11 AM, Daniel Borkmann wrote:
On 08/21/2018 06:46 PM, Jakub Kicinski wrote:
On Tue, Aug 21, 2018 at 6:12 PM, Taeung Song <treeze.taeung@xxxxxxxxx> wrote:
After the commit eac7d84519a3 ("tools: libbpf: don't return '.text'
as a program for multi-function programs"), bpf_program__next()
in bpf_object__for_each_program skips the function storage such as .text,
so eliminate the duplicate checking.

Cc: Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx>
Signed-off-by: Taeung Song <treeze.taeung@xxxxxxxxx>

Looks reasonable, but you may need to repost once bpf-next is open:

https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt

Acked-by: Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx>

Agree, please resubmit once bpf-next opens up again. Thanks!


OK ! I will.

Thanks,
Taeung