Re: [PATCH] net_sched: fix unused variable warning in stmmac
From: David Miller
Date: Thu Aug 23 2018 - 00:40:54 EST
From: Arnd Bergmann <arnd@xxxxxxxx>
Date: Wed, 22 Aug 2018 17:25:44 +0200
> The new tcf_exts_for_each_action() macro doesn't reference its
> arguments when CONFIG_NET_CLS_ACT is disabled, which leads to
> a harmless warning in at least one driver:
>
> drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c: In function 'tc_fill_actions':
> drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c:64:6: error: unused variable 'i' [-Werror=unused-variable]
>
> Adding a cast to void lets us avoid this kind of warning.
> To be on the safe side, do it for all three arguments, not
> just the one that caused the warning.
>
> Fixes: 244cd96adb5f ("net_sched: remove list_head from tc_action")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Applied, thanks Arnd.