Re: [PATCH v5 3/4] x86/boot/KASLR: Walk srat tables to filter immovable memory

From: Chao Fan
Date: Thu Aug 23 2018 - 03:33:08 EST


On Thu, Aug 23, 2018 at 03:25:35PM +0800, Baoquan He wrote:
[...]
>> +static void handle_immovable_mem(void)
>> +{
>> + char *args = (char *)get_cmd_line_ptr();
>> + struct acpi_table_header *table_header;
>> + struct acpi_subtable_header *table;
>> + struct acpi_srat_mem_affinity *ma;
>> + unsigned long table_end;
>> + int i = 0;
>> +
>> + if (!strstr(args, "movable_node"))
>
>If 'acpi=off' specified, better return too here.

Thanks, you are right.
Yes, I will think about it and add it to a suitable place.
May the position where we try to get the acpi table is better.
Or just here is also OK.

Thanks,
Chao Fan

>