Re: [PATCH 9/9] power: supply: twl4030-charger: fix OF sibling-node lookup

[Johan Hovold]

On Wed, Aug 22, 2018 at 11:36:58PM +0200, Sebastian Reichel wrote:
> Hi,
> 
> On Wed, Aug 22, 2018 at 12:55:47PM +0200, Johan Hovold wrote:
> > Use the new of_get_compatible_child() helper to lookup the usb sibling
> > node instead of using of_find_compatible_node(), which searches the
> > entire tree and thus can return an unrelated (non-sibling) node.
> > 
> > This also addresses a potential use-after-free (e.g. after probe
> > deferral) as the tree-wide helper drops a reference to its first
> > argument (i.e. the parent device node).
> > 
> > While at it, also fix the related phy-node reference leak.
> > 
> > Fixes: f5e4edb8c888 ("power: twl4030_charger: find associated phy by more reliable means.")
> > Cc: stable <stable@xxxxxxxxxxxxxxx>     # 4.2
> > Cc: NeilBrown <neilb@xxxxxxx>
> > Cc: Felipe Balbi <balbi@xxxxxx>
> > Cc: Sebastian Reichel <sre@xxxxxxxxxx>
> > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> > ---
> 
> Reviewed-by: Sebastian Reichel <sre@xxxxxxxxxx>

Thanks for reviewing.

Johan