Re: [PATCH v3] modules_install: make missing $DEPMOD a warning instead of an error

[H. Nikolaus Schaller]

Hi Randy,

> Am 23.08.2018 um 20:13 schrieb Randy Dunlap <rdunlap@xxxxxxxxxxxxx>:
> 
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> 
> When $DEPMOD is not found, only print a warning instead of exiting
> with an error message and error status.
> 
> Warning: 'make modules_install' requires /sbin/depmod. Please install it.
> This is probably in the kmod package.
> 
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Fixes: 934193a654c1 ("kbuild: verify that $DEPMOD is installed")
> Cc: stable@xxxxxxxxxxxxxxx
> Cc: Lucas De Marchi <lucas.demarchi@xxxxxxxxxxxxxx>
> Cc: Lucas De Marchi <lucas.de.marchi@xxxxxxxxx>
> Cc: Michal Marek <michal.lkml@xxxxxxxxxxx>
> Cc: Jessica Yu <jeyu@xxxxxxxxxx>
> Cc: Chih-Wei Huang <cwhuang@xxxxxxxxxxxx>
> Cc: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
> ---
> v2: add missing "exit 0" and update the commit message (no Error).
> v3: add Fixes: and Cc: stable
> 
> scripts/depmod.sh |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- lnx-418.orig/scripts/depmod.sh
> +++ lnx-418/scripts/depmod.sh
> @@ -15,9 +15,9 @@ if ! test -r System.map ; then
> fi
> 
> if [ -z $(command -v $DEPMOD) ]; then
> -	echo "'make modules_install' requires $DEPMOD. Please install it." >&2
> +	echo "Warning: 'make modules_install' requires $DEPMOD. Please install it." >&2
> 	echo "This is probably in the kmod package." >&2
> -	exit 1
> +	exit 0
> fi
> 
> # older versions of depmod require the version string to start with three
> 

works for me.

  INSTALL sound/usb/snd-usb-audio.ko - due to target is PHONY
  INSTALL sound/usb/snd-usbmidi-lib.ko - due to target is PHONY
  DEPMOD  4.18.4-letux+ - due to target is PHONY
Warning: 'make modules_install' requires /sbin/depmod. Please install it.
This is probably in the kmod package.

and returns success status.

BR and thanks,
Nikolaus Schaller