Re: [PATCH] media: camss: mark PM functions as __maybe_unused

From: Geert Uytterhoeven
Date: Thu Aug 23 2018 - 16:15:09 EST


On Fri, Aug 17, 2018 at 11:54 AM Arnd Bergmann <arnd@xxxxxxxx> wrote:
> The empty suspend/resume functions cause a build warning
> when they are unused:
>
> drivers/media/platform/qcom/camss/camss.c:1001:12: error: 'camss_runtime_resume' defined but not used [-Werror=unused-function]
> drivers/media/platform/qcom/camss/camss.c:996:12: error: 'camss_runtime_suspend' defined but not used [-Werror=unused-function]
>
> Mark them as __maybe_unused so the compiler can silently drop them.
>
> Fixes: 02afa816dbbf ("media: camss: Add basic runtime PM support")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds