Re: [PATCH v2 1/4] drivers: soc: Add broadcast base for Last Level Cache Controller (LLCC)

[vnkgutta]

On 2018-08-23 16:01, Evan Green wrote:
> On Fri, Aug 17, 2018 at 5:08 PM Venkata Narendra Kumar Gutta
> <vnkgutta@xxxxxxxxxxxxxx> wrote:
> > Currently, boradcast base is set to end of the LLCC banks, which may
>
> s/boradcast/broadcast/

I'll correct this typo in the next version.

> > not be correct always. As the number of banks may vary for each 
> > chipset
> > and the broadcast base could be at a different address as well. This 
> > info
> > depends on the chipset, so get the broadcast base info from the device
> > tree (DT). Add broadcast base in LLCC driver and use this for 
> > broadcast
> > writes.
> >
> > Signed-off-by: Venkata Narendra Kumar Gutta <vnkgutta@xxxxxxxxxxxxxx>
> > ---
> >  drivers/soc/qcom/llcc-slice.c      | 55 
> > +++++++++++++++++++++++---------------
> >  include/linux/soc/qcom/llcc-qcom.h |  4 +--
> >  2 files changed, 35 insertions(+), 24 deletions(-)
>
> Reviewed-by: Evan Green <evgreen@xxxxxxxxxxxx>