Re: [PATCH] x86/kvm/nVMX: avoid redundant double assignment of nested_run_pending

[Krish Sadhukhan]

On 08/23/2018 09:24 AM, Vitaly Kuznetsov wrote:
> nested_run_pending is set 20 lines above and check_vmentry_prereqs()/
> check_vmentry_postreqs() don't seem to be resetting it (the later, however,
> checks it).
>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>
> ---
>   arch/x86/kvm/vmx.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 6c3514750d0c..8a63b8cf9458 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -14221,9 +14221,6 @@ static int vmx_set_nested_state(struct kvm_vcpu *vcpu,
>   	    check_vmentry_postreqs(vcpu, vmcs12, &exit_qual))
>   		return -EINVAL;
>   
> -	if (kvm_state->flags & KVM_STATE_NESTED_RUN_PENDING)
> -		vmx->nested.nested_run_pending = 1;
> -
>   	vmx->nested.dirty_vmcs12 = true;
>   	ret = enter_vmx_non_root_mode(vcpu, NULL);
>   	if (ret)
Reviewed-by: Krish Sadhukhan <krish.sadhukhan@xxxxxxxxxx>