Re: [PATCH 4.4 018/107] x86/paravirt: Make native_save_fl() extern inline

From: Ben Hutchings
Date: Fri Aug 24 2018 - 19:08:14 EST

On Mon, 2018-07-23 at 14:41 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.ÂÂIf anyone has any objections, please let me know.
> ------------------
> From: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
> commit d0a8d9378d16eb3c69bd8e6d23779fbdbee3a8c7 upstream.
> native_save_fl() is marked static inline, but by using it as
> a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined.
> paravirt's use of native_save_fl() also requires that no GPRs other than
> %rax are clobbered.

Shouldn't native_restore_fl() be changed similarly? You added an out-
of-line definition, but it doesn't seem like it will actually be used.


Ben Hutchings, Software Developer  Codethink Ltd Dale House, 35 Dale Street
Manchester, M1 2HF, United Kingdom