RE: [PATCH V4 2/3] dt-bindings: input: Add document bindings for DA7280

[Roy Im]

Hi Pavel,

On Sunday, August 26, 2018 3:52 PM, Pavel Machek wrote:
>
> > +++ b/Documentation/devicetree/bindings/input/dlg,da7280.txt
> > @@ -0,0 +1,101 @@
> > +Dialog Semiconductor DA7280 Haptics bindings
> > +
> > +Required properties:
> > +- compatible: Should be "dlg,da7280".
> > +- reg: Specifies the I2C slave address.
> > +
> > +- interrupt-parent : Specifies the phandle of the interrupt
> > +controller to
> > +  which the IRQs from DA7280 are delivered to.
> > +
> > +- dlg,vib-mode:
> > +  "LRA-MODE" - Linear Resonance Actuator mode.
> > +  "ERM-BAR" - Bar type Eccentric Rotating Mass mode.
> > +  "ERM-COIN" - Coin type Eccentric Rotating Mass mode.
> 
> So this is some kind of "vibration motor" on steroids)?

I will add some descriptions more here in v5.

> > +- dlg,op-mode: Haptic operation mode.
> > +  Possible values:
> > +	1 - Direct register override mode triggered by i2c(default),
> > +	2 - PWM data source mode setting duty to 0 - 0xffff(0% - 100%),
> 
> Space after 0xffff?

I will remove this in v5.

> 
> > +	3 - Register triggered waveform memory mode, the pattern assigned
> > +	    to the PS_SEQ_ID played as much times as PS_SEQ_LOOP,
> > +	4 - Edge triggered waveform memory mode, external GPI(N) condtrol
> 
> "control"

I will fix this in v5

>
> > +	    are required to enable/disable and it needs to keep
> > +	    device enabled by sending magnitude (X > 0),
> > +	    the pattern is assigned to the GPI(N)_SEQUENCE_ID below
> 
> "below."

I will fix this in v5

> 
> > +- dlg,imax-microamp: Actuator max current rating.
> > +  Valid values: 0 - 252000.
> > +  Default: 130000.
> > +- dlg,impd-micro-ohms: the impedance of the actuator in micro ohm,
> 
> "ohms"

I will fix this in v5.

> 
> > +  as read from its datasheet.
> 
> "as read" does not sound english.

I will correct this in v5.

> 
> > +- dlg,mem-array: use in case that memory registers should be updated,
> > +  Please fill the whole buffers(100 bytes) to avoid any error in driver.
> > +  For example,
> > +	dlg,mem-array = <
> > +		0x01 0x02 0x03 0x04 0x05 0x06 0x07 0x08 0x09 0x0A
> > +		...
> > +		0x71 0x72 0x73 0x74 0x75 0x76 0x77 0x78 0x79 0x7A
> > +		0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
> > +		0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
> > +	>;
> 
> I'd not understand what this is from this description. (And I'd put
> example below... in the exampls section).

I will improve and update the description including the example section in v5.

Regards,
Roy

> 
> > +For further information, see device datasheet.
> > +
> > +======
> > +
> > +Example:
> > +
> > +	haptics: da7280-haptics@4a {
> > +		compatible = "dlg,da7280";
> > +		reg = <0x4a>;
> > +		interrupt-parent = <&gpio6>;
> > +		interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> > +		dlg,vib-mode = "LRA-MODE";
> > +		dlg,op-mode = <1>;
> > +		dlg,nom-microvolt = <2000000>;
> > +		dlg,abs-max-microvolt = <2000000>;
> > +		dlg,imax-microamp = <170000>;
> > +		dlg,resonant-freq-hz = <180>;
> > +		dlg,impd-micro-ohms = <10500000>;
> > +		dlg,freq-track-enable;
> > +		dlg,rapid-stop-enable;
> > +	};
> 
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures)
> http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html