Re: [PATCH V5 4/8] backlight: qcom-wled: Rename PM8941* to WLED3

From: Bjorn Andersson
Date: Mon Aug 27 2018 - 11:00:53 EST


On Mon 27 Aug 03:04 PDT 2018, Pavel Machek wrote:

> On Fri 2018-08-24 15:57:43, Kiran Gunda wrote:
> > Rename the PM8941* references as WLED3 to make the driver
> > generic and have WLED support for other PMICs. Also rename
> > "i_boost_limit" and "i_limit" variables to "boost_i_limit"
> > and "string_i_limit" respectively to resemble the corresponding
> > register names.
>
> Acked-by: Pavel Machek <pavel@xxxxxx>
>
> > -MODULE_DESCRIPTION("pm8941 wled driver");
> > +MODULE_DESCRIPTION("Qualcomm WLED driver");
>
> "... supporting pm8941, xxx devices" ?
>

I would suggest not doing this. There's quite a long list of different
PMICs containing some version of this hardware block.

Regards,
Bjorn