Re: [PATCH net-next 02/10] dt-bindings: net: ocelot: remove hsio from the list of register address spaces

From: Alexandre Belloni
Date: Mon Aug 27 2018 - 16:57:07 EST


On 16/08/2018 16:25:14+0200, Quentin Schulz wrote:
> Hi Alexandre,
>
> On Tue, Aug 14, 2018 at 02:41:35PM +0200, Alexandre Belloni wrote:
> > On 14/08/2018 08:49:53+0200, Quentin Schulz wrote:
> > > Understood but it's an intermediate patch. Later (patch 8), the SerDes
> > > muxing "controller" is added as a child to this node. There most likely
> > > will be some others in the future (temperature sensor for example).
> > >
> > > Furthermore, there's already a simple-mfd without children in this file:
> > > https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/mips/mscc.txt#L19
> > >
> > > How should we handle this case?
> > >
> >
> > There were child nodes in previous version of the binding. You can
> > remove simple-mfd now. The useful registers that are not used by any
> > drivers are gpr and chipid.
> >
>
> And what about the use case I'm facing? I've got child nodes defined in
> it but with a later patch (but they actually haven't made it to the
> DT binding documentation, so that's for the next version of the patch
> series).
>

I guess you should keep simple-mfd for hsio because it will have child
nodes.



--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com