Re: [PATCH v2 1/6] dt-bindings: reset: Add PDC Global binding for SDM845 SoCs

[sibis]

Hi Matthias,
Thanks for the review

On 2018-08-28 06:08, Matthias Kaehlcke wrote:
> Hi Sibi,
>
> On Fri, Aug 24, 2018 at 06:48:55PM +0530, Sibi Sankar wrote:
> > Add PDC Global(Power Domain Controller) binding for SDM845 SoCs.
>
> nit: missing blank before the opening parenthesis.

Will fix it

> > Signed-off-by: Sibi Sankar <sibis@xxxxxxxxxxxxxx>
> > ---
> >  .../bindings/reset/qcom,pdc-global.txt        | 52 
> > +++++++++++++++++++
> >  include/dt-bindings/reset/qcom,sdm845-pdc.h   | 20 +++++++
> >  2 files changed, 72 insertions(+)
> >  create mode 100644 
> > Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
> >  create mode 100644 include/dt-bindings/reset/qcom,sdm845-pdc.h
> >
> > diff --git 
> > a/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt 
> > b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
> > new file mode 100644
> > index 000000000000..69f9edca9503
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
> > @@ -0,0 +1,52 @@
> > +PDC Global
> > +======================================
> > +
> > +This binding describes a reset-controller found on PDC-Global(Power 
> > Domain
> > +Controller) block for Qualcomm Technologies Inc SDM845 SoCs.
>
> Are there other PDC reset controllers that aren't 'global'? Otherwise
> I'd suggest to use 'pdc-reset' instead of 'pdc-global', which is more
> specific and in line with the name of the driver added by this series.
> Or something like 'pdc-reset-global/main' if there are other
> controllers?

These are the only reset lines found in the pdc-global register space. 
But as
explained by Bjorn, wouldn't it be better to leave it as such since 
pdc-global
best describes the hardware without being limited by the current 
functionality
it is being used for?

> > +Required properties:
> > +- compatible:
> > +	Usage: required
> > +	Value type: <string>
> > +	Definition: must be:
> > +		    "qcom,sdm845-pdc-global"
> > +
> > +- reg:
> > +	Usage: required
> > +	Value type: <prop-encoded-array>
> > +	Definition: must specify the base address and size of the register
> > +	            space.
> > +
> > +- #reset-cells:
> > +	Usage: required
> > +	Value type: <uint>
> > +	Definition: must be 1; cell entry represents the reset index.
> > +
> > +Example:
> > +
> > +pdc_reset: reset-controller@b2e0000 {
> > +	compatible = "qcom,sdm845-pdc-global";
> > +	reg = <0xb2e0000 0x20000>;
> > +	#reset-cells = <1>;
> > +};
> > +
> > +PDC reset clients
> > +======================================
> > +
> > +Device nodes that need access to reset lines should
> > +specify them as a reset phandle in their corresponding node as
> > +specified in reset.txt.
> > +
> > +For list of all valid reset indicies see
>
> s/indicies/indices/ (or s/indicies/lines/ ?)
>
> Cheers
>
> Matthias