Re: [PATCH] perf annotate: Handle arm64 move instructions

From: Thomas-Mich Richter
Date: Tue Aug 28 2018 - 02:22:54 EST


On 08/27/2018 10:08 PM, Kim Phillips wrote:
> Add default handler for non-jump instructions. This really only has an
> effect on instructions that compute a PC-relative address, such as 'adrp,'
> as seen in these couple of examples:
>
> BEFORE: adrp x0, ffff20000aa11000 <kallsyms_token_index+0xce000>
> AFTER: adrp x0, kallsyms_token_index+0xce000
>
> BEFORE: adrp x23, ffff20000ae94000 <__per_cpu_load>
> AFTER: adrp x23, __per_cpu_load
>
> The implementation is identical to that of s390, but with a slight
> adjustment for objdump whitespace propagation (arm64 objdump puts
> spaces after commas, whereas s390's presumably doesn't).
>
> The mov__scnprintf() declaration is moved from s390's to arm64's
> instructions.c because arm64's gets included before s390's.
>

Tested-by: Thomas Richter <tmricht@xxxxxxxxxxxxx>

--
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
Vorsitzende des Aufsichtsrats: Martina Koederitz
GeschÃftsfÃhrung: Dirk Wittkopp
Sitz der Gesellschaft: BÃblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294