Re: [PATCH] ASoC: Convert to using %pOFn instead of device_node.name

From: Andy Shevchenko
Date: Tue Aug 28 2018 - 03:57:58 EST


On Tue, Aug 28, 2018 at 4:57 AM Rob Herring <robh@xxxxxxxxxx> wrote:

> In preparation to remove the node name pointer from struct device_node,
> convert printf users to use the %pOFn format specifier.

> + snprintf((char *)dai->platform_name, DAI_NAME_SIZE, "%llx.%pOFn",
> + (unsigned long long) res.start, dma_channel_np);

I understand that is not the part of the change, but wouldn't be good
to replace that ugly casting with proper specifier as well?
I mean
%pa ... &res.start

> + dev_err(&pdev->dev, "%pOFn sync own reference\n",
> + np);

One line?

--
With Best Regards,
Andy Shevchenko