Re: [PATCH v13 05/13] x86/msr: Add SGX definitions to msr-index.h

From: Jarkko Sakkinen
Date: Tue Aug 28 2018 - 04:11:33 EST


On Mon, Aug 27, 2018 at 12:42:32PM -0700, Dave Hansen wrote:
> On 08/27/2018 11:53 AM, Jarkko Sakkinen wrote:
> > @@ -866,10 +867,9 @@ void get_cpu_cap(struct cpuinfo_x86 *c)
> > }
> > }
> >
> > - /* Intel SGX features: level 0x00000012 */
> > - if (c->cpuid_level >= 0x00000012) {
> > - cpuid(0x00000012, &eax, &ebx, &ecx, &edx);
> > -
> > + /* Intel SGX features */
> > + if (c->cpuid_level >= SGX_CPUID) {
> > + cpuid(SGX_CPUID, &eax, &ebx, &ecx, &edx);
> > c->x86_capability[CPUID_12_EAX] = eax;
> > }
>
> This hunk has no apparent connection to the changelog.

Thanks for catching this, the same squashing mistake :-)

/Jarkko