Re: [GIT PULL] Staging/IIO driver patches for 4.19-rc1
From: Ahmed S. Darwish
Date: Tue Aug 28 2018 - 06:38:22 EST
[ re-send; forgotten lkml CC added; sorry ]
On Sat, 18 Aug 2018 17:57:24 +0200, Greg KH wrote:
> addition of some new IIO drivers. Also added was a "gasket" driver from
> Google that needs loads of work and the erofs filesystem.
Why are we adding __a whole new in-kernel framework__ for
developing basic user-space drivers?
We already have a frameowrk for that, and it's UIO.  The UIO
code is a very stable and simple subsystem; it's also heavily used
in the embedded industry..
I've looked at the gasket documentation , and the first user
of this new in-kernel API , and this is almost replicating UIO
it's not funny.  True, the gasket APIs adds some extra new
conveniences (PCI BAR re-mapping, MSI, ..), but there's no
technical reason this cannot be added to the UIO code instead.
More-over, the exposed user-space API is just some ioctls. So if
google hase some shipped user-space code that is using this,
hopefully the driver can still be re-implemented through UIO
without changing these bits..
 drivers/staging/gasket/gasket_core.h :: struct gasket_driver_desc