Re: [PATCH 4/5] perf/hw_breakpoint: Set breakpoint as disabled in modify_user_hw_breakpoint error path

[Arnaldo Carvalho de Melo]

Em Tue, Aug 28, 2018 at 04:38:23PM +0200, Jiri Olsa escreveu:
> On Tue, Aug 28, 2018 at 11:29:14AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Aug 09, 2018 at 06:30:15PM +0200, Jiri Olsa escreveu:
> > > On Thu, Aug 09, 2018 at 04:17:13PM +0200, Oleg Nesterov wrote:
> > > > On 08/09, Jiri Olsa wrote:
> > > > > -	if (err)
> > > > > +	if (err) {
> > > > > +		bp->attr.disabled = 1;
> > > > >  		return err;
> > > > 
> > > > Yes, but on the second thought... Can't we simply do
> > 
> > <SNIP>
> > 
> > > > instead of this and the next patch?
> > 
> > <SNIP>
> >  
> > > yep, seems good.. will send new version
> > 
> > Ok, but this is just for 4/5 and 5/5, right?
> 
> I resent v4 yesterday with final changes/acks, in here:
> 
> 7186 r   Aug 27 Jiri Olsa       (1.6K) [PATCHv4 0/5] perf/hw_breakpoint: Fix breakpoint modify

Ok, will search that, sorry for the noise :-)

- Arnaldo