Re: [PATCH] hwmon: Convert to using %pOFn instead of device_node.name
From: Rob Herring
Date: Tue Aug 28 2018 - 11:11:56 EST
On Tue, Aug 28, 2018 at 8:57 AM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>
> On 08/27/2018 06:52 PM, Rob Herring wrote:
> > In preparation to remove the node name pointer from struct device_node,
> > convert printf users to use the %pOFn format specifier.
> >
> > Cc: Jean Delvare <jdelvare@xxxxxxxx>
> > Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> > Cc: linux-hwmon@xxxxxxxxxxxxxxx
> > Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
>
> The devm_kstrdup((..., "iio_hwmon") is getting a bit ridiculous and is asking
> for a rewrite, but that can be done in a separate patch.
Yeah, I tend to think the drivers should just set a name rather than
pass thru whatever is in DT. If the DT follows good practice then the
node name is just going to reflect the generic class of device.
> Other than that, do you want this taken through hwmon or as a series on its own ?
You can take it.
Rob