Re: [PATCH v2 1/2] rtc: mips: default to rtc-cmos on mips

From: Paul Burton
Date: Tue Aug 28 2018 - 12:39:49 EST


Hi Arnd,

On Tue, Aug 28, 2018 at 04:26:30PM +0200, Arnd Bergmann wrote:
> The old rtc driver is getting in the way of some compat_ioctl
> simplification. Looking up the loongson64 git history, it seems
> that everyone uses the more modern but compatible RTC_CMOS driver
> anyway, so let's remove the special case for loongson64.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> arch/mips/Kconfig | 2 +-
> drivers/char/Kconfig | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)

Looks good to me - history suggests Loongson's RTC needs to use binary
mode for some reason but we've had that support for a while.

Presuming you want this to go through the RTC tree:

Acked-by: Paul Burton <paul.burton@xxxxxxxx>

Thanks,
Paul