Re: [PATCH 1/2] codafs: Fix build using bare-metal toolchain

From: Andy Shevchenko
Date: Tue Aug 28 2018 - 13:03:39 EST


On Tue, Aug 28, 2018 at 5:24 PM Sam Protsenko
<semen.protsenko@xxxxxxxxxx> wrote:
>
> The kernel is self-contained project and can be built with bare-metal
> toolchain. But bare-metal toolchain doesn't define u_quad_t type.
> Because of this codafs build fails when building with bare-metal
> toolchain. This patch fixes it by defining u_quad_t type in case when
> non-Linux toolchain is used.

> #endif /* !KERNEL */

I'm wondering what the heck KERNEL is doing in UAPI header.
Looks like this header is split wrongly in the first place.

> +#if defined(__KERNEL__) && !defined(__linux__) && !defined(_UQUAD_T_) && \

P.S. Actually it's the only header which uses KERNEL in UAPI.
Definitely it should be fixed first.

--
With Best Regards,
Andy Shevchenko