Re: [PATCH v7 12/24] pwm: jz4740: Use regmap and clocks from TCU driver

[Paul Burton]

Hi Thierry,

On Tue, Aug 21, 2018 at 07:16:23PM +0200, Paul Cercueil wrote:
> The ingenic-timer "TCU" driver provides us with a regmap, that we can
> use to safely access the TCU registers.
> 
> It also provides us with clocks, that can be (un)gated, reparented or
> reclocked from devicetree, instead of having these settings hardcoded in
> this driver.
> 
> While this driver is devicetree-compatible, it is never (as of now)
> probed from devicetree, so this change does not introduce a ABI problem
> with current devicetree files.
> 
> Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> ---
> 
> Notes:
>      v5: New patch
>     
>      v6: Drop requirement of probing from devicetree
>     
>      v7: No change
> 
>  drivers/pwm/Kconfig      |   2 +
>  drivers/pwm/pwm-jz4740.c | 124 +++++++++++++++++++++++++++++++----------------
>  2 files changed, 83 insertions(+), 43 deletions(-)

How do patches 12-16 of this series look to you from a drivers/pwm
perspective?

If you're happy with them it'd be great to get an ack so I can take this
through the MIPS tree along with the rest of the series.

Thanks,
    Paul