Re: [PATCH] locking/lockdep: Delete unnecesary #include

[Steven Rostedt]

On Tue, 28 Aug 2018 21:33:15 +0100
Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:

> Commit c3bc8fd637a9 ("tracing: Centralize preemptirq tracepoints and u
> nify their usage") added the inclusion of <trace/events/preemptirq.h>.
> liblockdep doesn't have a stub version of that header so now fails to
> build.
> 
> However, commit bff1b208a5d1 ("tracing: Partial revert of "tracing:
> Centralize preemptirq tracepoints and unify their usage"") removed the
> use of functions declared in that header.  So delete the #include.
> 
> Fixes: c3bc8fd637a9 ("tracing: Centralize preemptirq tracepoints ...")
> Fixes: bff1b208a5d1 ("tracing: Partial revert of "tracing: Centralize ...")
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>

Acked-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

Peter, you want to take this to Ingo?

-- Steve

> ---
>  kernel/locking/lockdep.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> index e406c5fdb41e..dd13f865ad40 100644
> --- a/kernel/locking/lockdep.c
> +++ b/kernel/locking/lockdep.c
> @@ -55,7 +55,6 @@
>  
>  #include "lockdep_internals.h"
>  
> -#include <trace/events/preemptirq.h>
>  #define CREATE_TRACE_POINTS
>  #include <trace/events/lock.h>
>