Re: [PATCH v2] clk: qcom: Add some missing gcc clks for msm8996

From: Stephen Boyd
Date: Tue Aug 28 2018 - 18:51:36 EST


Quoting Bjorn Andersson (2018-08-13 11:43:51)
> On Fri 10 Aug 08:11 PDT 2018, Stephen Boyd wrote:
>
> > Quoting Bjorn Andersson (2018-08-09 15:01:19)
> > > From: Rajendra Nayak <rnayak@xxxxxxxxxxxxxx>
> > >
> > > Add a few missing gcc clks for msm8996
> > >
> > > Signed-off-by: Rajendra Nayak <rnayak@xxxxxxxxxxxxxx>
> > > [bjorn: omit aggre0_noc_qosgen_extref_clk]
> > > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > > ---
> >
> > This is still going on?! I'm going to ignore Rob's auto email on this
> > patch.
> >
>
> There wasn't much "going on" since your last reply, found this on the
> floor between some chairs...
>
>
> The issue pointed to you on v1 was that there was another patch that
> already added two of the clocks, so this v2 simply drops the two
> duplicated clocks; i.e. solves the merge conflict.
>
> What I see now is that I did forget to carry Rob's R-b from v1.
>

Ok. I see that I had applied it and then held off because of the
duplicate entry error. I'll add Rob's reviewed-by and take this patch
instead of the one I had months ago. Sad that we lose the proper parent
linkage.