Re: [PATCH v13 03/16] s390, kexec_file: drop arch_kexec_mem_walk()

[AKASHI Takahiro]

On Tue, Aug 28, 2018 at 09:43:47PM +0800, Dave Young wrote:
> Hi AKASHI,
> On 08/28/18 at 02:21pm, AKASHI Takahiro wrote:
> > Hi Dave,
> > 
> > On Thu, Aug 09, 2018 at 12:14:05AM -0400, Pingfan Liu wrote:
> > > 
> > > 
> > > 
> > > 
> > > ----- Original Message -----
> > > > From: "Dave Young" <dyoung@xxxxxxxxxx>
> > > > To: "AKASHI Takahiro" <takahiro.akashi@xxxxxxxxxx>, "Philipp Rudo" <prudo@xxxxxxxxxxxxx>, "catalin marinas"
> > > > <catalin.marinas@xxxxxxx>, "will deacon" <will.deacon@xxxxxxx>, dhowells@xxxxxxxxxx, vgoyal@xxxxxxxxxx,
> > > > herbert@xxxxxxxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, bhe@xxxxxxxxxx, arnd@xxxxxxxx, schwidefsky@xxxxxxxxxx, "heiko
> > > > carstens" <heiko.carstens@xxxxxxxxxx>, "ard biesheuvel" <ard.biesheuvel@xxxxxxxxxx>, "james morse"
> > > > <james.morse@xxxxxxx>, bhsharma@xxxxxxxxxx, kexec@xxxxxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx,
> > > > linux-kernel@xxxxxxxxxxxxxxx, "piliu@xxxxxxxxxx Thiago Jung Bauermann" <bauerman@xxxxxxxxxxxxxxxxxx>
> > > > Sent: Thursday, August 9, 2018 11:34:16 AM
> > > > Subject: Re: [PATCH v13 03/16] s390, kexec_file: drop arch_kexec_mem_walk()
> > > > 
> > > > Add more cc. Pingfan Liu confirmed ppc does not use 0 as valid address,
> > > > if so it should be safe.
> > > > 
> > > > Pingfan, can you add more words?
> > > > 
> > > 
> > > ppc64 uses a few KB starting from 0 for exception handler.
> > 
> > It assures that 0 (zero) is valid, but won't be assigned as a result of
> > kexec_add_buffer().
> > 
> > So do you think that yet I should submit another patch set, introducing
> > explicit KEXEC_BUF_MEM_UNKNOWN, while assuming 0 by default is safe for now?
> > 
> > Now that this is the only comment against my v13, it's up to you.
> 
> I'm fine with your proposal.  It is simple enough, and we can look into
> it when it becomes a problem in the future which is unlikely.

Ok, thank you for this confirmation.

-Takahiro AKASHI

> Thanks
> Dave