RE: [PATCH v13 02/13] x86/cpufeature: Add SGX and SGX_LC CPU features

[Huang, Kai]

> -----Original Message-----
> From: Jarkko Sakkinen [mailto:jarkko.sakkinen@xxxxxxxxxxxxxxx]
> Sent: Tuesday, August 28, 2018 7:17 PM
> To: Huang, Kai <kai.huang@xxxxxxxxx>
> Cc: x86@xxxxxxxxxx; platform-driver-x86@xxxxxxxxxxxxxxx; Hansen, Dave
> <dave.hansen@xxxxxxxxx>; Christopherson, Sean J
> <sean.j.christopherson@xxxxxxxxx>; nhorman@xxxxxxxxxx;
> npmccallum@xxxxxxxxxx; linux-sgx@xxxxxxxxxxxxxxx; Kai Huang
> <kai.huang@xxxxxxxxxxxxxxx>; Thomas Gleixner <tglx@xxxxxxxxxxxxx>; Ingo
> Molnar <mingo@xxxxxxxxxx>; H. Peter Anvin <hpa@xxxxxxxxx>; Borislav
> Petkov <bp@xxxxxxx>; Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>;
> David Woodhouse <dwmw@xxxxxxxxxxxx>; open list:X86 ARCHITECTURE (32-
> BIT AND 64-BIT) <linux-kernel@xxxxxxxxxxxxxxx>
> Subject: Re: [PATCH v13 02/13] x86/cpufeature: Add SGX and SGX_LC CPU
> features
> 
> On Tue, Aug 28, 2018 at 12:07:41AM +0000, Huang, Kai wrote:
> > > +#define X86_FEATURE_SGX_LC		(16*32+30) /* supports SGX
> launch
> > > configuration */
> >
> > Sorry if it was me who wrote the comment "SGX launch configuration". I
> > think we should just use "SGX launch control". :)
> 
> Not sure if we should change though. The former is more self-explaining, the
> latter is "more official".

I'll let you decide.  To me the comment should explain what does "LC" mean, and to me it means "launch control". :)

Thanks,
-Kai
> 
> /Jarkko