Re: [PATCH v2] pinctrl/amd: use byte access to clear irq/wake status bits

From: Linus Walleij
Date: Wed Aug 29 2018 - 07:55:39 EST

On Wed, Aug 22, 2018 at 6:57 PM Daniel Kurtz <djkurtz@xxxxxxxxxxxx> wrote:

> Commit 6afb10267c1692 ("pinctrl/amd: fix masking of GPIO interrupts")
> changed to the clearing of interrupt status bits to a RMW in a critical
> section. This works, but is a bit overkill.
> The relevant interrupt/wake status bits are in the Most Significant Byte
> of a 32-bit word. These two are the only write-able bits in this byte.
> Therefore, it should be safe to just write these bits back as a byte
> access without any additional locking.
> Signed-off-by: Daniel Kurtz <djkurtz@xxxxxxxxxxxx>

The build robot is complaining about the syntax.
Is this fixable? Maybe you already sent a new patch... I will
see when I reach the top of my inbox.

Linus Walleij