Re: [RFC PATCH 6/6] x86/alternatives: remove text_poke() return value

From: Nadav Amit
Date: Wed Aug 29 2018 - 13:15:35 EST


at 2:52 AM, Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:

>> --- a/arch/x86/kernel/alternative.c
>> +++ b/arch/x86/kernel/alternative.c
>> @@ -795,7 +795,7 @@ static void text_poke_safe(void *addr, const void *opcode, size_t len,
>> *
>> * Note: Must be called under text_mutex.
>> */
>> -void *text_poke(void *addr, const void *opcode, size_t len)
>> +void text_poke(void *addr, const void *opcode, size_t len)
>> {
>> bool cross_page_boundary = offset_in_page(addr) + len > PAGE_SIZE;
>> struct page *pages[2] = {0};
>
> Could you also remove "return addr;" in this patch ?

Oops. Thanks!