Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style

From: Larry Finger
Date: Wed Aug 29 2018 - 17:22:00 EST

On 08/29/2018 04:14 PM, Joe Perches wrote:
On Wed, 2018-08-29 at 21:35 +0100, John Whitmore wrote:
Rename the bit field element AdvCoding, as it causes a checkpatch issue
with CamelCase naming. As the element is not actually used in code it
has been renamed to 'not_used_adv_coding'.

The single line of code which initialises the bit has been removed,
as the field is unused.

This is a purely coding style change which should have no impact
on runtime code execution.

Hi John.

Other than the somewhat useful code style cleanups, is there
a point at which you will feel comfortable doing actual code
changes to this driver?

Perhaps support for the chipset could be converted to use
mac80211 and moved into the directory with the other realtek
drivers in drivers/net/wireless/realtek/rtl8xxxu/...

Larry? What do you think?

First of all, if a variable is not used, then it should be removed, not merely renamed to satisfy checkpatch.

All the Realtek USB devices should be added to rtl8xxxu, not merely moved into that directory. Jes Sorensen created a well-designed driver the is structured to permit addition of different initialization routines, etc. That said, the conversion will not be easy. In addition, it will require having your hands on a real device - a requirement that I cannot meet for the RTL8192U.