Re: [PATCH] gpio: Add driver for PC Engines APU2/APU3 GPIOs

[Florian Eckert]

On 2018-08-24 12:56, Piotr KrÃl wrote:
> On 08/03/2018 09:08 PM, Andy Shevchenko wrote:
>
> Hi Andy,
>
> (...)
>
> > > +#define APU_FCH_ACPI_MMIO_BASE 0xFED80000
> > > +#define APU_FCH_GPIO_BASE      (APU_FCH_ACPI_MMIO_BASE + 0x1500)
> >
> > Wow! Can we see ACPI tables for these boards? Care to share (via some
> > file share service) output of `acpidump -o tables.dat` ?
>
> Please find acpidump [1]. FYI I'm PC Engines firmware maintainer
> (firmware is coreboot based), so I can fix required things. I'm pretty
> sure that ACPI tables are not in best shape.

Thanks for the dump,

By the way I have seen that the driver
https://github.com/torvalds/linux/blob/master/drivers/gpio/gpio-amdpt.c
is using the acpi to get the mmio address. I think this is the way to go
to get the acpi mmio address in the gpio-apu driver as well.

What is the right "acpi_device_id" for the APU3?
https://github.com/torvalds/linux/blob/master/drivers/gpio/gpio-amdpt.c#L146