Re: [PATCH v2] riscv: Do not overwrite initrd_start and initrd_end

From: Geert Uytterhoeven
Date: Thu Aug 30 2018 - 05:01:01 EST


Hi Guenter,

On Wed, Aug 29, 2018 at 2:34 AM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> setup_initrd() overwrites initrd_start and initrd_end if __initramfs_size
> is larger than 0, which is always true even if there is no embedded
> initramfs. This prevents booting qemu with "-initrd" parameter.
> Overwriting initrd_start and initrd_end is not necessary since
> __initramfs_start and __initramfs_size are used directly in

... since commit df52092f3c977885 ("fastboot: remove duplicate
unpack_to_rootfs()")...

To avoid -stable backporting this beyond v2.6.30 ;-)

> populate_rootfs() to load the built-in initramfs, so just drop
> that code.
>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds